Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: reset stores cache before loading cluster info (#4942) #4957

Merged
merged 4 commits into from
Sep 21, 2022
Merged

cluster: reset stores cache before loading cluster info (#4942) #4957

merged 4 commits into from
Sep 21, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4942

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Close #4941.

What is changed and how does it work?

This PR resets the new leader store cache after transferring the PD leader.

Check List

Tests

  • Unit test

Release note

Fix the issue that the removed tombstone store shows again after transferring the PD leader

@rleungx @ti-chi-bot
reset stores cache before loading cluster info
eaf3e5d 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx @ti-chi-bot
address the comment
449f2e4 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request May 16, 2022
Merged
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/cluster Cluster logic. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick. labels May 16, 2022
@rleungx rleungx force-pushed the cherry-pick-4942-to-release-5.2 branch from d05b07d to 21f8a20 Compare May 27, 2022 09:54
@rleungx
fix the conflict
5becbd0 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the cherry-pick-4942-to-release-5.2 branch from 21f8a20 to 5becbd0 Compare May 27, 2022 09:59
@codecov
Copy link

codecov bot commented May 29, 2022 •
edited
Loading

Codecov Report

Base: 74.93% // Head: 74.74% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (be2efa8) compared to base (8c4c7a9).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-5.2    #4957      +/-   ##
===============================================
- Coverage        74.93%   74.74%   -0.20%     
===============================================
  Files              249      249              
  Lines            25761    25765       +4     
===============================================
- Hits             19304    19257      -47     
- Misses            4768     4802      +34     
- Partials          1689     1706      +17
Flag Coverage Δ
unittests 74.74% <80.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 82.01% <50.00%> (-0.10%) ⬇️
server/core/basic_cluster.go 91.42% <100.00%> (+0.14%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/kv/etcd_kv.go 69.56% <0.00%> (-10.15%) ⬇️
server/tso/tso.go 64.48% <0.00%> (-6.02%) ⬇️
server/region_syncer/server.go 84.44% <0.00%> (-5.93%) ⬇️
pkg/dashboard/adapter/manager.go 78.72% <0.00%> (-4.26%) ⬇️
server/schedule/region_scatterer.go 78.99% <0.00%> (-4.21%) ⬇️
server/member/member.go 63.10% <0.00%> (-3.75%) ⬇️
server/election/leadership.go 83.90% <0.00%> (-3.45%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 21, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 21, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

@nolouch: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 21, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5becbd0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c7dcc3c into tikv:release-5.2 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@nolouch nolouch nolouch approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

Assignees

@rleungx rleungx

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cluster Cluster logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @nolouch @rleungx @VelocityLight